Entry resource #95
Merged
Entry resource #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 73.40% 73.30% -0.11%
==========================================
Files 69 70 +1
Lines 4211 4254 +43
==========================================
+ Hits 3091 3118 +27
- Misses 855 864 +9
- Partials 265 272 +7
Continue to review full report at Codecov.
|
camdencheek
reviewed
Aug 18, 2020
| } | ||
|
|
||
| entry.Timestamp = typedEvent.LastTimestamp.Time | ||
| entry.AddLabel("event_type", string(event.Type)) | ||
| k.Write(ctx, entry) |
There was a problem hiding this comment.
I'm not seeing any change that would affect write_to. Could you explain what changed?
There was a problem hiding this comment.
When you use NewEntry, it uses the write_to field when constructing the entry.
camdencheek
approved these changes
Aug 18, 2020
djaglowski
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added
Resourcefield was added to EntryIdentifierhelper was created to assist with writing toResourceRemoved
Tagsfield was removed from EntryChanged
host_metadataoperator now writes to an entry'sResourcefield, instead of Labelshost_labelerhelper has been renamedhost_identifiermetadataoperator embeds theIdentifierhelper and supports writing toResourceIdentifierhelper and support writing toResourcek8s_eventoperator now supports thewrite_to,labels, andresourceconfiguration optionsPlease check that the PR fulfills these requirements